Skip to content

upport log_max_age#2

Open
7ing wants to merge 4 commits into
mailgun:masterfrom
7ing:logmaxage
Open

upport log_max_age#2
7ing wants to merge 4 commits into
mailgun:masterfrom
7ing:logmaxage

Conversation

@7ing

@7ing 7ing commented Dec 16, 2016

Copy link
Copy Markdown

LogMaxAge is the maximum # of days (exclusive) to retain old files based on the timestamp encoded in their filename.
log_max_age <= 0 means delete immediately, otherwise it retains the files that are created within logMaxAge days.

LogMaxAge is the maximum # of days (exclusive) to retain old files based on the timestamp encoded in their filename.
log_max_age <= 0 means delete immediately, otherwise it retains the files that are created within logMaxAge days.
@7ing

7ing commented Dec 16, 2016

Copy link
Copy Markdown
Author

@thrawn01 @klizhentas @k-pom @anton-efimenko @pirogoeth
anyone maintain this repo? looks like the CI has very old version for GO, which makes the checks fails.

@thrawn01

thrawn01 commented Dec 16, 2016

Copy link
Copy Markdown

@7ing Thanks for the Pull Request!

In your pull request, remove the old golang versions from travis.yml and add 1.6 and 1.7 as the test targets

Then we can go from there.

@7ing

7ing commented Dec 16, 2016

Copy link
Copy Markdown
Author

@thrawn01 thanks for your reply. travis tries to install github.com/axw/gocov/gocov, but it does exist any more, can I remove those steps as well?

@thrawn01

Copy link
Copy Markdown

Yes, remove all the following

install:
 - export PATH=$HOME/gopath/bin:$PATH
 - go get -v github.com/axw/gocov
 - go install github.com/axw/gocov/gocov
 - go get -v github.com/golang/glog
 - go get -v launchpad.net/gocheck
 - go get -v github.com/mailgun/glogutils

and replace with

install:
  - go get -t .

go get -t . will retrieve all the dependencies needed by the code

@7ing

7ing commented Dec 16, 2016

Copy link
Copy Markdown
Author

@thrawn01 seems the test requires gocov

gocov test -exclude-goroot | gocov report
/home/travis/build.sh: line 57: gocov: command not found
/home/travis/build.sh: line 57: gocov: command not found

@thrawn01

Copy link
Copy Markdown

just remove

  - gocov test -exclude-goroot | gocov report

from travis for now. We can always setup coveralls.io later if we want

@7ing

7ing commented Dec 16, 2016

Copy link
Copy Markdown
Author

@thrawn01 sure it works. Thanks for your quick response on this PR.

@7ing

7ing commented Jan 12, 2017

Copy link
Copy Markdown
Author

any updates on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants