upport log_max_age#2
Conversation
LogMaxAge is the maximum # of days (exclusive) to retain old files based on the timestamp encoded in their filename. log_max_age <= 0 means delete immediately, otherwise it retains the files that are created within logMaxAge days.
|
@thrawn01 @klizhentas @k-pom @anton-efimenko @pirogoeth |
|
@7ing Thanks for the Pull Request! In your pull request, remove the old golang versions from travis.yml and add 1.6 and 1.7 as the test targets Then we can go from there. |
|
@thrawn01 thanks for your reply. travis tries to install github.com/axw/gocov/gocov, but it does exist any more, can I remove those steps as well? |
|
Yes, remove all the following install:
- export PATH=$HOME/gopath/bin:$PATH
- go get -v github.com/axw/gocov
- go install github.com/axw/gocov/gocov
- go get -v github.com/golang/glog
- go get -v launchpad.net/gocheck
- go get -v github.com/mailgun/glogutilsand replace with install:
- go get -t .
|
|
@thrawn01 seems the test requires gocov
|
|
just remove - gocov test -exclude-goroot | gocov reportfrom travis for now. We can always setup coveralls.io later if we want |
|
@thrawn01 sure it works. Thanks for your quick response on this PR. |
|
any updates on this ? |
LogMaxAge is the maximum # of days (exclusive) to retain old files based on the timestamp encoded in their filename.
log_max_age <= 0 means delete immediately, otherwise it retains the files that are created within logMaxAge days.