Improve search by ignoring accents and use primary language for terms#131
Open
microstudi wants to merge 2 commits intomainio:mainfrom
Open
Improve search by ignoring accents and use primary language for terms#131microstudi wants to merge 2 commits intomainio:mainfrom
microstudi wants to merge 2 commits intomainio:mainfrom
Conversation
…#8) * Improve search by ignoring accents and use primary language for terms * remove uniq * address review * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * fix order of search * address review * hardden unicode marks * better namimg * cops * fix backend --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
microstudi
changed the title
There was a problem hiding this comment.
Pull request overview
This PR aims to improve term/translation searching by making term matching accent-insensitive and by preferring primary-language (e.g., English) source terms as a fallback when a locale is missing translations.
Changes:
- Add Unicode normalization (diacritic/mark stripping) to
TranslationStore#by_termmatching. - Update
TranslationDirectorysearch behavior to merge locale results with primary-language fallback results. - Extend specs to cover accent-insensitive search and fallback/merge behavior across locales.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
lib/decidim/term_customizer/translation_store.rb |
Normalizes strings (NFD + strip Unicode marks) to make term search accent-insensitive. |
lib/decidim/term_customizer/translation_directory.rb |
Refactors search to merge locale and primary-language results (currently incomplete/broken). |
spec/lib/decidim/term_customizer/translation_store_spec.rb |
Adds coverage for accent-insensitive term searches and non-diacritic Unicode mark handling. |
spec/lib/decidim/term_customizer/translation_directory_spec.rb |
Adds scenarios for accent-insensitive searches and primary-language fallback behavior when locale translations are missing/overlapping. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the following problems: