Skip to content

chore: use serenity songbird next branch #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuyaprgrm merged 1 commit into from
Apr 1, 2026
Merged

chore: use serenity songbird next branch #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ name = "text-to-speech-rs"
version = "0.1.0"
edition = "2024"

[build-dependencies]
vergen-gitcl = { version = "9.1.0", features = ["build", "cargo"] }

Comment on lines +6 to +8
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[build-dependencies] are only built/used when the crate has a build script (build.rs) or a build = "..." entry in [package]. This repo currently has no build script, so adding vergen-gitcl here has no effect other than extra dependency resolution/fetch. Either add and wire up a build script that uses vergen-gitcl, or remove this build-dependency.

Suggested change
[build-dependencies]
vergen-gitcl = { version = "9.1.0", features = ["build", "cargo"] }

Copilot uses AI. Check for mistakes.
[profile.release]
strip = true
lto = "thin"
Expand All @@ -25,7 +28,7 @@ sha2 = "0.10.9"
hex = "0.4.3"
tracing = "0.1.43"
tracing-subscriber = { version = "0.3.22", features = ["env-filter"] }
songbird = { git = "https://github.com/beerpsi-forks/songbird", rev = "25195877c715e08df25eda668df6b3a6bb3d3cdf", features = [
songbird = { git = "https://github.com/serenity-rs/songbird", branch = "next", features = [
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a moving git branch (branch = "next") makes builds non-reproducible in repos that don't commit Cargo.lock (and this repo currently has no lockfile). Prefer pinning to a specific rev (or commit Cargo.lock if this is an application) so CI and users don't get unexpected breakage when the branch advances.

Suggested change
songbird = { git = "https://github.com/serenity-rs/songbird", branch = "next", features = [
songbird = { git = "https://github.com/serenity-rs/songbird", rev = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa", features = [

Copilot uses AI. Check for mistakes.
"builtin-queue",
] }
poise = "0.6.1"
Expand Down
Loading