Fix Jupyter notebook keyboard input handling#60
Merged
brendancol merged 1 commit intomasterfrom Feb 27, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data-lm-suppress-shortcutsattribute to prevent JupyterLab/Lumino from intercepting keyboard shortcuts on the viewer widget, instead ofstopPropagation()which blocked ipyevents from receiving key eventsxdeleting cells) from firing while the viewer is focusedescapeandxexit keys in Jupyter since they're too easy to hit accidentally — usewidget.stop()insteadwait=0for lower-latency keyboard/mouse inputTest plan
explore()viewer in JupyterLab — verify WASD/arrow keys, R/Shift+R, H, and mouse controls all work without triggering notebook shortcutsxandescapedo not close the viewerwidget.stop()still works to close the viewer