chore(propel-docs): set up Cloudflare Workers static-assets deploy#234
Merged
Conversation
Configure apps/propel-docs for deployment on Cloudflare Workers (Static Assets), driven by Cloudflare's Git integration (no GitHub Actions): - wrangler.jsonc: enable workers.dev + per-version preview URLs, set not_found_handling to "404-page" (correct for a multi-page static site, unlike the SPA fallback Storybook uses), and drop the account_id TODO (the account comes from the connected Cloudflare account, not config). Left a TODO for the custom-domain route + astro `site` once a domain is assigned. - Add src/pages/404.astro so "404-page" handling has a real dist/404.html to serve, styled with the site's BaseLayout + design tokens.
|
📚 Storybook preview: https://pr-234-propel-storybook.vamsi-906.workers.dev |
There was a problem hiding this comment.
Pull request overview
Prepares apps/propel-docs for deployment to Cloudflare Workers (Static Assets) via Cloudflare’s Git integration (Workers Builds), aligning configuration with the existing Storybook Workers deploy approach in the repo.
Changes:
- Updated
apps/propel-docs/wrangler.jsoncto enableworkers_dev+preview_urlsand setassets.not_found_handlingto"404-page"for a multi-page static site. - Added an Astro
404page (apps/propel-docs/src/pages/404.astro) so the build emits a real 404 page for Cloudflare to serve.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/propel-docs/wrangler.jsonc | Configures Cloudflare Workers Static Assets deployment (workers.dev + preview URLs, 404 handling). |
| apps/propel-docs/src/pages/404.astro | Adds a styled 404 page so "404-page" handling can serve dist/404.html. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+16
to
+18
| // TODO: once a production domain is assigned, add a custom-domain route here and set | ||
| // `site` in astro.config.mjs to match (so the sitemap emits absolute URLs). Mirror | ||
| // packages/propel/wrangler.jsonc's storybook route, e.g.: |
Integrate the Vite+ -> Turborepo toolchain migration (#235), which also renamed apps/propel-docs -> apps/docs. Conflicts resolved: - apps/docs/wrangler.jsonc: kept the Cloudflare Workers static-assets deploy config from this branch (workers_dev + preview_urls, not_found_handling '404-page', no account_id — driven by Cloudflare Git integration). Worker name kept as 'propel-docs' to mirror the 'propel-storybook' sibling (CF worker names are account-global), dropping main's stale account_id TODO. - apps/docs/src/pages/404.astro: relocated from the old apps/propel-docs path into the renamed apps/docs tree. Validated on the merged Turborepo toolchain: pnpm install (up to date), turbo build --filter=docs (astro check 0 errors; dist/404.html generated), check:format + check:lint clean.
vihar
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Makes
apps/propel-docsready to deploy on Cloudflare Workers (Static Assets), driven by Cloudflare's Git integration (Workers Builds) — no GitHub Actions workflow. Mirrors the conventions already used for the Storybook deploy inpackages/propel/wrangler.jsonc.Changes
apps/propel-docs/wrangler.jsoncworkers_dev+preview_urls→ every non-production branch/PR build gets its own preview URL.assets.not_found_handling: "404-page"— correct for a multi-page static site. (Storybook usessingle-page-applicationbecause it is a SPA; here that would wrongly return200for every bad path.)account_idTODO — the account comes from the connected Cloudflare account, not this file.routesentry + Astrositeonce a domain is assigned.apps/propel-docs/src/pages/404.astro(new)"404-page"handling has a realdist/404.htmlto serve. Uses the site'sBaseLayout+ design tokens.Verification
vp run @makeplane/propel-docs#build→ clean, 9 pages,dist/404.htmlemitted.astro check→ 0 errors / 0 warnings / 0 hints.vp check→ changed files format-clean.Deploying (Cloudflare Workers Builds dashboard)
vpis a local dependency, sopnpm exec vpworks in Cloudflare's build image (no global install needed):main/) — build packs@makeplane/propelfrom the workspace firstpnpm exec vp run @makeplane/propel-docs#buildpnpm exec wrangler deploy --config apps/propel-docs/wrangler.jsoncCurrently workers.dev-only; add the custom-domain route + set
siteonce a domain is assigned.