-
Notifications
You must be signed in to change notification settings - Fork 1
chore: migrate toolchain from Vite+ (vp) to Turborepo + standalone tools #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
8e1a79a
chore: migrate toolchain from Vite+ (vp) to Turborepo + standalone tools
sriramveeraghanta 911421d
chore: adopt plane-ee check:*/fix:* tooling; rename propel-docs → docs
sriramveeraghanta c8257b2
chore: remove pre-commit hooks
sriramveeraghanta 51685fd
chore: ignore dist/** in oxlint config
sriramveeraghanta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,6 +33,9 @@ storybook-static | |
| # Astro build cache | ||
| .astro | ||
|
|
||
| # Turborepo cache | ||
| .turbo | ||
|
|
||
| # Test coverage | ||
| coverage | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "ignorePatterns": ["**/dist/**", "**/.claude/**", "**/.agents/**"], | ||
| "sortTailwindcss": { | ||
| "functions": ["cva", "cx"], | ||
| "stylesheet": "packages/propel/tailwind.css" | ||
| }, | ||
| "sortImports": true, | ||
| "sortPackageJson": true, | ||
| "jsdoc": true | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "$schema": "./node_modules/oxlint/configuration_schema.json", | ||
| "jsPlugins": ["./tools/oxlint-plugin-propel/src/index.ts"], | ||
| "ignorePatterns": [ | ||
| "**/dist/**", | ||
| "**/.claude/**", | ||
| "**/.agents/**", | ||
| "**/.storybook/**", | ||
| "**/storybook-static/**", | ||
| "**/vitest.config.ts", | ||
| "**/tsdown.config.ts" | ||
| ], | ||
| "rules": { | ||
| "propel/prefer-tailwind-v4-shorthand": "error", | ||
| "typescript/consistent-type-definitions": ["error", "type"] | ||
| } | ||
| } | ||
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,18 @@ | ||
| <!--VITE PLUS START--> | ||
| # Toolchain: pnpm + Turborepo | ||
|
|
||
| # Using Vite+, the Unified Toolchain for the Web | ||
|
|
||
| This project is using Vite+, a unified toolchain built on top of Vite, Rolldown, Vitest, tsdown, Oxlint, Oxfmt, and Vite Task. Vite+ wraps runtime management, package management, and frontend tooling in a single global CLI called `vp`. Vite+ is distinct from Vite, and it invokes Vite through `vp dev` and `vp build`. Run `vp help` to print a list of commands and `vp <command> --help` for information about a specific command. | ||
|
|
||
| Docs are local at `node_modules/vite-plus/docs` or online at https://viteplus.dev/guide/. | ||
| This monorepo uses [pnpm](https://pnpm.io) (workspaces + catalog) for package | ||
| management and [Turborepo](https://turborepo.com) to orchestrate tasks. The | ||
| underlying tools run standalone: [tsdown](https://tsdown.dev) for library builds, | ||
| [Vitest](https://vitest.dev) for tests, and [Oxlint](https://oxc.rs) + [Oxfmt](https://oxc.rs) | ||
| for linting and formatting. Config lives in `turbo.json`, `.oxlintrc.json`, | ||
| `.oxfmtrc.json`, and per-package `tsdown.config.ts` / `vitest.config.ts`. | ||
|
|
||
| ## Review Checklist | ||
|
|
||
| - [ ] Run `vp install` after pulling remote changes and before getting started. | ||
| - [ ] Run `vp check` and `vp test` to format, lint, type check and test changes. | ||
| - [ ] Check if there are `vite.config.ts` tasks or `package.json` scripts necessary for validation, run via `vp run <script>`. | ||
| - [ ] If setup, runtime, or package-manager behavior looks wrong, run `vp env doctor` and include its output when asking for help. | ||
|
|
||
| <!--VITE PLUS END--> | ||
| - [ ] Run `pnpm install` after pulling remote changes and before getting started. | ||
| - [ ] Run `pnpm check` (check:format + check:lint + check:types) and `pnpm test` | ||
| before pushing. Use `pnpm fix` to auto-fix formatting + lint. | ||
| - [ ] Scripts follow a `check:*` / `fix:*` convention (`check:lint`, `check:format`, | ||
| `check:types`; `fix:lint`, `fix:format`), each a Turbo task defined in `turbo.json` | ||
| and per-package `package.json`. Run one package with | ||
| `pnpm exec turbo run <task> --filter=<package>`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.