Switch source from tagged services to custom repository of entities#1
Open
Nerobrain wants to merge 5 commits intomakinacorpus:masterfrom
Nerobrain:master
Open
Switch source from tagged services to custom repository of entities#1Nerobrain wants to merge 5 commits intomakinacorpus:masterfrom Nerobrain:master
Nerobrain wants to merge 5 commits intomakinacorpus:masterfrom
Nerobrain:master
Conversation
JS extracted to external source. Try to impliment `tags` functionality of select2
Member
|
Wow, thanks a lot for this! There's a lot of interesting changes in there, but the pull request is too big, I'd like to have multiple but smaller issues to review. I'll try to take some time to comment, can't do right now, but in the next few days I'll do a complete review. |
Member
|
Ok, it's been a long time, first of all, I have lots of notes about your changes:
That said, there's probably some nice modifications within your changes, but you should fix the rest first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry for my bad english. Just try to use and extend your bundle.