Quick Connect UX Improvement - Fix major delay#136
Open
grimyfishtank wants to merge 1 commit intomalbeclabs:mainfrom
Open
Quick Connect UX Improvement - Fix major delay#136grimyfishtank wants to merge 1 commit intomalbeclabs:mainfrom
grimyfishtank wants to merge 1 commit intomalbeclabs:mainfrom
Conversation
Remove compromised polyfill.io script and load MathJax asynchronously to unblock DOMContentLoaded and allow immediate button interactivity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Quick Connect page (
/quick-connect/) has a noticeable delay before the network selection buttons become interactive. Users can see the buttons, but clicking them does nothing until the page fully loads several seconds later.Root Cause
Two external scripts in
extra_javascriptare loaded as synchronous (blocking)<script>tags:polyfill.io— This domain was compromised in a supply chain attack in 2024. The domain is now unreliable and causes the browser to hang for 30+ seconds waiting for a timeout beforeDOMContentLoadedfires.Swapping-sol-to-2z.md).Since the connection wizard attaches its click handlers on
DOMContentLoaded, these blocking scripts prevent all button interactivity until they finish loading (or timeout).Fix
polyfill.io— compromised and unnecessary (all modern browsers support ES6 natively)async— prevents it from blocking the DOM parser and page interactivity