cli: add local route-table fallback for public IP detection#2963
Open
cli: add local route-table fallback for public IP detection#2963
Conversation
262b711 to
96c3e01
Compare
This was referenced Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #2962
Summary of Changes
is_public_ipv4()that rejects all IANA-reserved, private, loopback, link-local, CGNAT, documentation/test, multicast, and reserved ranges — equivalent to nightlyIpv4Addr::is_global()get_public_ipv4_via_route()) so public IP detection works whenifconfig.meis unreachableget_public_ipv4()to try HTTP first, then fall back to the routing-table approach with the new address validationTesting Verification
rust-test,rust-build,rust-lintall passing in CI