e2e: use subtests for qa multi-tunnel setup phases#3042
Open
e2e: use subtests for qa multi-tunnel setup phases#3042
Conversation
Wrap each setup phase (unicast connect, multicast setup, add multicast tunnel, verify IBRL healthy) in t.Run subtests for better test output granularity. Each phase bails out early via t.Failed() if a prior phase fails. Also fix pre-existing ineffassign lint warning in qa_alldevices_unicast_test.go.
- Add safety-net disconnect cleanup before Phase 1 to catch partially-connected clients if the test bails out early - Strengthen shared-state comment to note sequential constraint - Remove t.Failed() bail-out after Phase 4 so validation subtests still run and provide diagnostic output even if IBRL check fails
packethog
force-pushed
the
ss/qa-multitunnel-subtests
branch
from
9965482 to
9727731
Compare
snormore
reviewed
Feb 18, 2026
packethog
force-pushed
the
ss/qa-multitunnel-subtests
branch
from
f74b695 to
1c8f60c
Compare
snormore
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestQA_MultiTunnel(unicast connect, multicast setup, add multicast tunnel, verify IBRL healthy) int.Runsubtests for better test output granularity and easier debugging when a specific phase failserrgroupinstead of connecting sequentiallyineffassignlint warning inqa_alldevices_unicast_test.goTesting Verification