Conversation
Signed-off-by: Razvan Deaconescu <razvan.deaconescu@cs.pub.ro>
`facts.pl` stores generated Prolog facts. `factsAndRules.pl` is generated by concatenating the generated `facts.pl` files and the existing `rules.pl` file. Signed-off-by: Razvan Deaconescu <razvan.deaconescu@cs.pub.ro>
Make the following changes: * The script requires a single argument: the sandbox profile file (in SBPL format). * Check program arguments and print usage message in case of incorrect number of arguments. * Print user messages for each step. * Hardcode file names: `facts.pl`, `rules.pl`, `factsAndRules.pl`. * Update `README.md` accordingly. Add sample usage. Signed-off-by: Razvan Deaconescu <razvan.deaconescu@cs.pub.ro>
Signed-off-by: Razvan Deaconescu <razvan.deaconescu@cs.pub.ro>
Add FIXME comment to investigate the issue. Signed-off-by: Razvan Deaconescu <razvan.deaconescu@cs.pub.ro>
Signed-off-by: Razvan Deaconescu <razvan.deaconescu@cs.pub.ro>
Signed-off-by: Razvan Deaconescu <razvan.deaconescu@cs.pub.ro>
teodutu
suggested changes
May 4, 2021
teodutu
left a comment
teodutu
left a comment
Member
There was a problem hiding this comment.
Everything is in order as far as I can tell, except for a few typos. I'm unsure, however, whether we should keep both smartPly.py and sandscout_compiler.py as they both seem to be the same thing.
| It uses Prolog-based queries to evaluate file-based security properties of iOS sandbox profiles. | ||
|
|
||
| The [SandScout paper](https://dl.acm.org/doi/10.1145/2976749.2978336) (`SandScout: Automatic Detection of Flaws in iOS Sandbox Profiles`), presented at ACM CCS 2016, details the architecture and implementation of SandScout and our findings. | ||
| In the paper SandScout was used to evaluate the `container` sandbox profile for iOS 9.0.2 and discover seven classes of exploitable vulnerabilities. |
|
|
||
| %Query 4 is similar to query 2, but it only show subpaths and literals that are in /private/var/mobile | ||
|
|
||
| % Query 4 is similar to query 2, but it only show subpaths and literals that are in /private/var/mobile |
| @@ -1,4 +1,5 @@ | |||
| #!/usr/bin/env python | |||
| #!/usr/bin/env python3 | |||
Member
There was a problem hiding this comment.
What seems to be a copy of this string has already been refactored in this PR #1. Is it worth keeping both of them?
|
|
||
| %Query 4 is similar to query 2, but it only show subpaths and literals that are in /private/var/mobile | ||
|
|
||
| % Query 4 is similar to query 2, but it only show subpaths and literals that are in /private/var/mobile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the following changes: