Add string start addresses to -strings output#100
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Each entry in the -strings output now includes a Start field with the virtual address of the string's bytes in the binary, enabling RE tools like IDA and Binary Ninja to create string literals at exact addresses.
kami922
force-pushed
the
issue-99-string-addresses
branch
from
June 30, 2026 22:48
bbfbe16 to
f0025dc
Compare
Collaborator
|
The implementation looks good here, CI error suggests a test needs updated however |
Collaborator
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #99
Summary
StringEntrystruct (Str string,Start uint64) toobjfile/strings.go— replaces barestringin the outputExtractStrings()now returns[]StringEntryinstead of[]string; the start VA comes directly fromc.Pointerwhich was already computed during blob walkingExtractMetadata.Stringsinmain.gofrom[]stringto[]objfile.StringEntry-humanoutput now prints0x<addr> <string>per entryStringEntrymessage toGoReSym.proto; changedrepeated string strings→repeated StringEntry strings.Strfield and assertStart != 0for every extracted stringExample output change
Before:
After:
Notes
Startis included per Steve's guidance — consumers can deriveEndfromStart + len(Str)🤖 Generated with Claude Code