Rewrite GDB server in Python#297
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a GDB compatibility proxy (GdbCompatibilityProxy) to provide Windows process metadata (such as loaded PE images, thread info, and TEB address) to Unicorn's GDB server, enabling better integration with debuggers like IDA Pro. The review feedback highlights several areas for improvement, including correcting the RSP packet size calculation to account for framing overhead, preventing proxy execution if stopped during connection retries, properly closing the DefaultSelector to avoid resource leaks, addressing compatibility risks with the hardcoded qSupported response, and updating test assertions to validate the full packet length.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
eb50de7 to
8e71c4e
Compare
8e71c4e to
83278a7
Compare
The upstream udbserver dependency was not working correctly (missing packets, no proper stop reasons etc), so I had the clanker (gpt-5.6-sol) rewrite it completely in Python.