Skip to content

Align src codestyle fixes#289

Open
billy1arm wants to merge 1 commit into
masterfrom
billy1arm/codestyle-src-fixes
Open

Align src codestyle fixes#289
billy1arm wants to merge 1 commit into
masterfrom
billy1arm/codestyle-src-fixes

Conversation

@billy1arm

@billy1arm billy1arm commented Jul 1, 2026

Copy link
Copy Markdown
Member

Fix the flagged src/CMakeLists.txt control-paren spacing and brace the single-line file-close path in IntermediateValues.\n\nCo-authored-by: Copilot 223556219+Copilot@users.noreply.github.com


This change is Reviewable

Fix the flagged src/CMakeLists.txt control-paren spacing and brace the single-line file-close path in IntermediateValues.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 1, 2026 22:30

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR applies small, style-focused cleanup to align with the project’s codestyle: it adjusts CMake if(...) spacing and makes the debug-output file-close path in the MMAP intermediate value writer explicitly braced.

Changes:

  • Update src/CMakeLists.txt to use if (COND) spacing for several build-option checks.
  • Refactor the DEBUG_WRITE macro in IntermediateValues.cpp to brace the fclose path while preserving the unconditional progress printf.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
src/tools/Extractor_projects/Movemap-Generator/IntermediateValues.cpp Braces the fclose control flow in the debug-write macro for clearer structure.
src/CMakeLists.txt Applies consistent control-paren spacing in several if statements.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@billy1arm billy1arm left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@r-log This looks very wrong. Don't intend to merge this, but those if statements look wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants