feat: Integrate @maniac-tech/react-native-expo-read-sms at 9.1.2 on Expo SDK 52#23
Open
maniac-tech wants to merge 5 commits intomasterfrom
Open
feat: Integrate @maniac-tech/react-native-expo-read-sms at 9.1.2 on Expo SDK 52#23maniac-tech wants to merge 5 commits intomasterfrom
@maniac-tech/react-native-expo-read-sms at 9.1.2 on Expo SDK 52#23maniac-tech wants to merge 5 commits intomasterfrom
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification branch for
react-native-expo-read-smsPR #99 — confirms the library at9.1.2builds and runs correctly on Expo SDK 52 / React Native 0.76.Changes
package.json@maniac-tech/react-native-expo-read-sms:8.0.2-alpha→^9.1.2react-native:0.74.3→0.74.5expo-build-properties:~0.12.3→~0.12.5@babel/core:^7.12.9→^7.24.0react-native-paper,react-native-web,react-dom,expo-updatesbuild:androidscript for EAS buildsexporeadsms-test→expo-read-sms-test-appapp.jsonandroid.permissions— now correctly declaresRECEIVE_SMSandREAD_SMS(was empty[])minSdkVersion:34→23(the previous value blocked all Android 5.0–13 devices)expo-updatesplugin,runtimeVersion,extra.eas)ExpoReadSMS-Test→ExpoReadSMS-TestAppApp.jsreact-native-paperUI with a minimal plain React Native UIcheckIfHasSMSPermission()— displays both permission flagsrequestReadSMSPermission()— triggers system dialog, then re-checks statusstartReadSMS(callback)— starts listener; logs received SMS bodystopReadSMS()— stops listener; confirms via loguseApphook dependency (previously coupled to old UI).gitignore/androidand/ios— generated native folders excluded from version control (generated viaexpo prebuild)readme.mdsdk-51throughsdk-54)Testing
Verification Checklist
npx expo prebuild+npx expo run:androidsucceed)checkIfHasSMSPermission()— returns correct{ hasReadSmsPermission, hasReceiveSmsPermission }objectrequestReadSMSPermission()— system dialog appears; returnstruewhen grantedstartReadSMS(callback)— starts without error; callback fires withstatus === "success"[phoneNumber, messageBody]valuesstopReadSMS()— stops listener; no further callbacks after stoppingNativeEventEmitterwarnings in consoleRelated