Skip to content

Clear the refresh spinner when an article fails to load (closes #197) #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jim-daf wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Clear the refresh spinner when an article fails to load (closes #197) #198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions app/src/main/java/com/manuelmaly/hn/ArticleReaderActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import android.os.Bundle;
import android.os.Handler;
import android.os.Looper;
import android.util.Log;

import androidx.appcompat.app.AppCompatActivity;
import androidx.core.view.MenuItemCompat;
Expand Down Expand Up @@ -267,6 +268,8 @@ private void setShowRefreshing(boolean showRefreshing) {
}

private class HNReaderWebViewClient extends WebViewClient {
private static final String TAG = "HNReaderWebViewClient";

@Override
public void onPageStarted(WebView view, String url, Bitmap favicon) {
setShowRefreshing(true);
Expand All @@ -283,6 +286,13 @@ public void onPageFinished(WebView view, String url) {
super.onPageFinished(view, url);
}

@Override
public void onReceivedError(WebView view, int errorCode, String description, String failingUrl) {
Log.w(TAG, "Article load failed " + errorCode + ": " + description + " @ " + failingUrl);
setShowRefreshing(false);
mWebViewIsLoading = false;
}

@Override
public boolean shouldOverrideUrlLoading( WebView view, String url ) {
view.loadUrl( url );
Expand Down