Bugfix: an endpoint without a parent contaminated with its predecessor's parent.#126
Open
rczajka wants to merge 4 commits into
Open
Bugfix: an endpoint without a parent contaminated with its predecessor's parent.#126rczajka wants to merge 4 commits into
rczajka wants to merge 4 commits into
Conversation
Contributor
Author
|
Yes. Other than the PRs you referenced, there's one-line change in 089f754, which adds |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
/another-login/endpoint only worked correctly, because it was preceded by a pattern with an empty parent. Had the previous parent been not empty (as in the amended test), the last pattern would've been rendered as/router/another-login/, because of theparent_patternvariable reuse in the fixed loop.