Fix Reminder E-Mail only contains last issue link after Update to 2.30#19
Open
pattyland wants to merge 1 commit into
Open
Fix Reminder E-Mail only contains last issue link after Update to 2.30#19pattyland wants to merge 1 commit into
pattyland wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a regression introduced in v2.30 where grouped reminder emails only contained the last issue link instead of all matching issues.
The issue list was overwritten while building the grouped email body. This PR changes the affected assignments back to append operations so that all issue entries are preserved in the generated reminder email.
Problem
After updating to v2.30, reminder emails sent by the plugin may miss multiple issue links. Although
bug_reminder_mail_test.phpcan still show the expected output, the actually sent grouped reminder emails only include the last issue for each recipient/group.Fix
$listinstead of overwriting the existing list.Related issue
Fixes #18