Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-persister-query-key-infer.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@tanstack/query-core': patch
---

fix(query-core): wrap `persister`'s `TQueryKey` in `NoInfer` so that the `persister` slot no longer contributes to `TQueryKey` inference. Follow-up to #10510, which removed `NoInfer` on all three `persister` generics. Preserving `NoInfer<TQueryKey>` keeps that fix's benefit for `TQueryFnData` while preventing `TQueryKey` from widening to the augmented constraint when `Register.queryKey` is narrowed — which made `DataTag`-branded wrapper returns un-assignable in contravariant slots.
5 changes: 5 additions & 0 deletions .changeset/query-devtools-onclose-setter-type.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@tanstack/query-devtools': patch
---

Update the devtools panel `setOnClose` callback type to return `void`.
4 changes: 2 additions & 2 deletions packages/query-core/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ export interface QueryOptions<
> {
/**
* If `false`, failed queries will not retry by default.
* If `true`, failed queries will retry infinitely., failureCount: num
* If `true`, failed queries will retry infinitely.
* If set to an integer number, e.g. 3, failed queries will retry until the failed query count meets that number.
* If set to a function `(failureCount, error) => boolean` failed queries will retry until the function returns false.
*/
Expand All @@ -246,7 +246,7 @@ export interface QueryOptions<
*/
gcTime?: number
queryFn?: QueryFunction<TQueryFnData, TQueryKey, TPageParam> | SkipToken
persister?: QueryPersister<TQueryFnData, TQueryKey, TPageParam>
persister?: QueryPersister<TQueryFnData, NoInfer<TQueryKey>, TPageParam>
queryHash?: string
queryKey?: TQueryKey
queryKeyHashFn?: QueryKeyHashFunction<TQueryKey>
Expand Down
4 changes: 2 additions & 2 deletions packages/query-devtools/src/TanstackQueryDevtoolsPanel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class TanstackQueryDevtoolsPanel {
#initialIsOpen: Signal<boolean | undefined>
#errorTypes: Signal<Array<DevtoolsErrorType> | undefined>
#hideDisabledQueries: Signal<boolean | undefined>
#onClose: Signal<(() => unknown) | undefined>
#onClose: Signal<(() => void) | undefined>
#Component: DevtoolsComponentType | undefined
#theme: Signal<Theme | undefined>
#dispose?: () => void
Expand Down Expand Up @@ -90,7 +90,7 @@ class TanstackQueryDevtoolsPanel {
this.#client[1](client)
}

setOnClose(onClose: () => unknown) {
setOnClose(onClose: () => void) {
this.#onClose[1](() => onClose)
}

Expand Down
Loading