Add daily overview navigation from weekly overview with intelligent work period detection by Copilot · Pull Request #128 · maorun/timeTrack.nvim

Copilot · 2025-09-30T12:11:43Z

Latest Fixes (Commit):

Fixed overlapping entries handling: Changed gap calculation from prev_entry.endTime to current_period.end_time to properly handle overlapping time entries
Fixed pause time distribution logic: Replaced incorrect division by period count with proper pause time calculation between work periods (pauseTime / (#workPeriods - 1) for gaps)
Prevented division by zero: Added proper checks for empty work periods array before performing calculations

Technical Improvements:

Work period detection now correctly handles overlapping time entries
Pause time is accurately distributed between actual work periods
Robust error handling prevents runtime crashes from empty data
All 169 tests continue to pass

Original prompt

This section details on the original issue you should resolve

<issue_title>weeklyOverview für nur einen Tag</issue_title>
<issue_description>benutze die .github/copilot-instructions.md

von der weeklyOverview soll man in die Tage gehen können und von dem einen Tag eine Übersicht bekommen:

wie lange gearbeitet wurde (auch ob tagesziel erreicht oder nicht)

von wann bis wann (mit Pause) insgesamt gearbeitet wurde: also: 8-12 Uhr Pause: 1h 13-17 Uhr

an welchen Projekten/Dateien, wie lange insgesamt gearbeitet wurde an dem Tag in Minuten</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes #127

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: maorun <2291503+maorun@users.noreply.github.com>

Copilot

Pull Request Overview

This PR implements a daily overview navigation feature from the weekly overview, allowing users to access detailed daily views for individual days by pressing keys 1-7. The implementation provides comprehensive daily summaries including goal achievement status, work periods with pause calculations, and project/file breakdowns displayed in minutes.

Key Changes

Added daily overview navigation from weekly overview (keys 1-7 for Monday-Sunday)
Implemented German-language daily overview interface with goal tracking and time period formatting
Added comprehensive test coverage for daily summary calculations and UI integration

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
lua/maorun/time/core.lua	Adds `getDailySummary()` function to calculate detailed daily data including work periods, project hours, and goal achievement
lua/maorun/time/ui.lua	Implements daily overview UI with German interface, floating window navigation, and keyboard handlers for 1-7 keys
lua/maorun/time/init.lua	Exposes new daily overview functions through the public API
test/weekly_overview_spec.lua	Adds 5 comprehensive test cases covering daily summary calculations and UI integration

Copilot · 2025-09-30T17:54:29Z

lua/maorun/time/ui.lua

+    table.insert(
+        content,
+        'Drücke 1-7 für Tagesübersicht (Mo-So): 1=Mo, 2=Di, 3=Mi, 4=Do, 5=Fr, 6=Sa, 7=So'
+    )


Duplicate help text lines are added to the content. Remove the duplicate line 784-787 to avoid displaying the same instruction twice.

Suggested change

table.insert(

content,

'Drücke 1-7 für Tagesübersicht (Mo-So): 1=Mo, 2=Di, 3=Mi, 4=Do, 5=Fr, 6=Sa, 7=So'

)

Copilot · 2025-09-30T17:54:29Z

lua/maorun/time/ui.lua

+                string.format(
+                    '│ Format: %s-%s Uhr  Pause: %.1fh  %s-%s Uhr             │',
+                    os.date('%H', summary.earliestStart),
+                    os.date('%H', summary.earliestStart + 4 * 3600), -- Simplified: assume 4h + pause + remaining
+                    summary.pauseTime,
+                    os.date('%H', summary.latestEnd - 4 * 3600),
+                    os.date('%H', summary.latestEnd)
+                )


The hardcoded 4-hour assumption in the work period format is overly simplistic and may not represent actual work patterns. Consider calculating actual work periods based on the time entries instead of using a fixed 4-hour split.

Suggested change

string.format(

'│ Format: %s-%s Uhr Pause: %.1fh %s-%s Uhr │',

os.date('%H', summary.earliestStart),

os.date('%H', summary.earliestStart + 4 * 3600), -- Simplified: assume 4h + pause + remaining

summary.pauseTime,

os.date('%H', summary.latestEnd - 4 * 3600),

os.date('%H', summary.latestEnd)

)

(function()

-- Try to display actual work periods if available

if summary.workPeriods and #summary.workPeriods == 2 then

local p1 = summary.workPeriods[1]

local p2 = summary.workPeriods[2]

return string.format(

'│ Format: %s-%s Uhr Pause: %.1fh %s-%s Uhr │',

os.date('%H', p1.start),

os.date('%H', p1["end"]),

summary.pauseTime,

os.date('%H', p2.start),

os.date('%H', p2["end"])

)

else

-- Fallback: show start, pause, end

return string.format(

'│ Format: %s-%s Uhr Pause: %.1fh %s-%s Uhr │',

os.date('%H', summary.earliestStart),

os.date('%H', summary.earliestStart + ((summary.latestEnd - summary.earliestStart - summary.pauseTime * 3600) / 2)),

summary.pauseTime,

os.date('%H', summary.latestEnd - ((summary.latestEnd - summary.earliestStart - summary.pauseTime * 3600) / 2)),

os.date('%H', summary.latestEnd)

)

end

end)()

maorun · 2025-09-30T17:57:31Z

@copilot

The hardcoded 4-hour assumption in the work period format is overly simplistic and may not represent actual work patterns. Consider calculating actual work periods based on the time entries instead of using a fixed 4-hour split.
Duplicate help text lines are added to the content. Remove the duplicate line 784-787 to avoid displaying the same instruction twice.
Das neue Feature muss in der readme.md erwähnt werden

…cumentation Co-authored-by: maorun <2291503+maorun@users.noreply.github.com>

Copilot · 2025-09-30T18:05:39Z

@copilot

The hardcoded 4-hour assumption in the work period format is overly simplistic and may not represent actual work patterns. Consider calculating actual work periods based on the time entri...

Fixed all three issues in commit 386d3f7:

Replaced hardcoded 4-hour assumption with dynamic work period calculation that analyzes actual time entries and detects breaks ≥30 minutes to create realistic work sessions (e.g., "8-17 Uhr Pause: 2.0h 19-21 Uhr" instead of hardcoded "8-12 Uhr Pause: 1.0h 13-17 Uhr")
Removed duplicate help text line - navigation instructions now appear only once in weekly overview
Added comprehensive daily overview documentation to README.md with 75+ lines covering navigation, features, sample output, and programmatic usage

The new work period algorithm adapts to any work schedule pattern and provides accurate time representations based on actual work data.

Copilot

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Copilot · 2025-09-30T18:34:48Z

lua/maorun/time/ui.lua

+                local periods_text = table.concat(
+                    period_strings,
+                    '  Pause: '
+                        .. string.format('%.1fh', summary.pauseTime / #summary.workPeriods)


Division by zero potential when #summary.workPeriods is 0. This could cause a runtime error if summary.workPeriods is an empty table.

Suggested change

local periods_text = table.concat(

period_strings,

' Pause: '

.. string.format('%.1fh', summary.pauseTime / #summary.workPeriods)

local work_period_count = #summary.workPeriods

local pause_per_period = work_period_count > 0 and (summary.pauseTime / work_period_count) or 0

local periods_text = table.concat(

period_strings,

' Pause: '

.. string.format('%.1fh', pause_per_period)

Copilot · 2025-09-30T18:34:48Z

lua/maorun/time/ui.lua

+                local period_strings = {}
+                for _, period in ipairs(summary.workPeriods) do
+                    table.insert(
+                        period_strings,
+                        string.format(
+                            '%s-%s Uhr',
+                            os.date('%H', period.start),
+                            os.date('%H', period.end_time)
+                        )
+                    )
+                end
+
+                local periods_text = table.concat(
+                    period_strings,
+                    '  Pause: '
+                        .. string.format('%.1fh', summary.pauseTime / #summary.workPeriods)
+                        .. '  '
+                )


The condition checks for non-empty workPeriods but the division at line 1763 still assumes #summary.workPeriods > 0. However, this check should prevent the division by zero, but the logic for distributing pause time across periods may not be correct - it divides total pause time by number of periods rather than calculating actual pause time between specific periods.

Suggested change

local period_strings = {}

for _, period in ipairs(summary.workPeriods) do

table.insert(

period_strings,

string.format(

'%s-%s Uhr',

os.date('%H', period.start),

os.date('%H', period.end_time)

)

)

end

local periods_text = table.concat(

period_strings,

' Pause: '

.. string.format('%.1fh', summary.pauseTime / #summary.workPeriods)

.. ' '

)

-- Sort workPeriods by start time, just in case

table.sort(summary.workPeriods, function(a, b) return a.start < b.start end)

local period_strings = {}

for i, period in ipairs(summary.workPeriods) do

local period_str = string.format(

'%s-%s Uhr',

os.date('%H', period.start),

os.date('%H', period.end_time)

)

table.insert(period_strings, period_str)

-- If not the last period, calculate pause to next period

if i < #summary.workPeriods then

local next_period = summary.workPeriods[i + 1]

local pause_seconds = next_period.start - period.end_time

if pause_seconds > 0 then

local pause_hours = pause_seconds / 3600

table.insert(period_strings, string.format('Pause: %.1fh', pause_hours))

end

end

end

local periods_text = table.concat(period_strings, ' ')

Copilot · 2025-09-30T18:34:49Z

lua/maorun/time/core.lua

+        -- Calculate gap between previous end and current start
+        local gap = curr_entry.startTime - prev_entry.endTime


The gap calculation uses prev_entry.endTime but should use the end_time from current_period to handle overlapping entries correctly. When entries overlap, the previous entry's end time may not be the actual end of the current work period.

Suggested change

-- Calculate gap between previous end and current start

local gap = curr_entry.startTime - prev_entry.endTime

-- Calculate gap between current period's end and current entry's start

local gap = curr_entry.startTime - current_period.end_time

maorun · 2025-09-30T18:36:32Z

@copilot

The gap calculation uses prev_entry.endTime but should use the end_time from current_period to handle overlapping entries correctly. When entries overlap, the previous entry's end time may not be the actual end of the current work period.
The condition checks for non-empty workPeriods but the division at line 1763 still assumes #summary.workPeriods > 0. However, this check should prevent the division by zero, but the logic for distributing pause time across periods may not be correct - it divides total pause time by number of periods rather than calculating actual pause time between specific periods.
Division by zero potential when #summary.workPeriods is 0. This could cause a runtime error if summary.workPeriods is an empty table.

…tion, division by zero Co-authored-by: maorun <2291503+maorun@users.noreply.github.com>

Copilot · 2025-09-30T18:45:11Z

@copilot

The gap calculation uses prev_entry.endTime but should use the end_time from current_period to handle overlapping entries correctly. When entries overlap, the previous entry's end time ma...

Fixed all three issues in commit a98a64f:

Gap calculation with overlapping entries: Changed from prev_entry.endTime to current_period.end_time to properly handle overlapping time entries by using the actual end time of the current work period
Pause time distribution logic: Replaced incorrect division pauseTime / #workPeriods with proper calculation: pauseTime / (#workPeriods - 1) for multiple periods or full pauseTime for single period
Division by zero prevention: Added proper safety checks if summary.workPeriods and #summary.workPeriods > 0 before performing calculations

The fixes ensure robust error handling and accurate work period detection. All 169 tests continue to pass.

Copilot

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

lua/maorun/time/core.lua:1

Potential division by zero error when there's only one work period. The condition checks for multiple periods but the division could still fail if #summary.workPeriods equals 1.

local Path = require('plenary.path')

Copilot · 2025-09-30T21:19:01Z

lua/maorun/time/ui.lua

+                table.insert(
+                    content,
+                    string.format('│ Format: %s                     │', periods_text)


[nitpick] The hardcoded spacing in the format string may not align properly with different period text lengths. Consider using dynamic padding based on the content length or a fixed-width approach.

Suggested change

table.insert(

content,

string.format('│ Format: %s │', periods_text)

-- Pad or truncate periods_text to fit the box width

local function pad_or_truncate(str, width)

if #str > width then

return str:sub(1, width)

else

return str .. string.rep(' ', width - #str)

end

end

local content_width = 51 -- 62 (box width) - 10 ('│ Format: ') - 1 ('│')

table.insert(

content,

string.format('│ Format: %s│', pad_or_truncate(periods_text, content_width))

Initial plan

ca3b517

Copilot AI assigned Copilot and maorun Sep 30, 2025

Copilot started work on behalf of maorun September 30, 2025 12:11 View session

Implement daily overview feature with navigation from weekly overview

cf20f64

Co-authored-by: maorun <2291503+maorun@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] weeklyOverview für nur einen Tag~~ Add daily overview navigation from weekly overview (weeklyOverview für nur einen Tag) Sep 30, 2025

Copilot AI requested a review from maorun September 30, 2025 12:26

Copilot finished work on behalf of maorun September 30, 2025 12:26

maorun marked this pull request as ready for review September 30, 2025 17:42

maorun requested a review from Copilot September 30, 2025 17:53

Copilot AI reviewed Sep 30, 2025

View reviewed changes

Copilot started work on behalf of maorun September 30, 2025 17:57 View session

Fix hardcoded work periods, remove duplicate help text, add README do…

386d3f7

…cumentation Co-authored-by: maorun <2291503+maorun@users.noreply.github.com>

Copilot AI changed the title ~~Add daily overview navigation from weekly overview (weeklyOverview für nur einen Tag)~~ Add daily overview navigation from weekly overview with intelligent work period detection Sep 30, 2025

Copilot finished work on behalf of maorun September 30, 2025 18:06

maorun requested a review from Copilot September 30, 2025 18:33

Copilot AI reviewed Sep 30, 2025

View reviewed changes

Copilot started work on behalf of maorun September 30, 2025 18:36 View session

Fix work period calculation bugs: overlapping entries, pause distribu…

a98a64f

…tion, division by zero Co-authored-by: maorun <2291503+maorun@users.noreply.github.com>

Copilot finished work on behalf of maorun September 30, 2025 18:45

maorun requested a review from Copilot September 30, 2025 21:18

Copilot AI reviewed Sep 30, 2025

View reviewed changes

maorun merged commit e71fec6 into master Oct 1, 2025
6 checks passed

maorun deleted the copilot/fix-3e6f892d-3cad-402a-ad7c-84ef383e553e branch October 1, 2025 06:44

-                string.format(
-                    '│ Format: %s-%s Uhr  Pause: %.1fh  %s-%s Uhr             │',
-                    os.date('%H', summary.earliestStart),
-                    os.date('%H', summary.earliestStart + 4 * 3600), -- Simplified: assume 4h + pause + remaining
-                    summary.pauseTime,
-                    os.date('%H', summary.latestEnd - 4 * 3600),
-                    os.date('%H', summary.latestEnd)
-                )
+                (function()
+                    -- Try to display actual work periods if available
+                    if summary.workPeriods and #summary.workPeriods == 2 then
+                        local p1 = summary.workPeriods[1]
+                        local p2 = summary.workPeriods[2]
+                        return string.format(
+                            '│ Format: %s-%s Uhr  Pause: %.1fh  %s-%s Uhr             │',
+                            os.date('%H', p1.start),
+                            os.date('%H', p1["end"]),
+                            summary.pauseTime,
+                            os.date('%H', p2.start),
+                            os.date('%H', p2["end"])
+                        )
+                    else
+                        -- Fallback: show start, pause, end
+                        return string.format(
+                            '│ Format: %s-%s Uhr  Pause: %.1fh  %s-%s Uhr             │',
+                            os.date('%H', summary.earliestStart),
+                            os.date('%H', summary.earliestStart + ((summary.latestEnd - summary.earliestStart - summary.pauseTime * 3600) / 2)),
+                            summary.pauseTime,
+                            os.date('%H', summary.latestEnd - ((summary.latestEnd - summary.earliestStart - summary.pauseTime * 3600) / 2)),
+                            os.date('%H', summary.latestEnd)
+                        )
+                    end
+                end)()

		-- Calculate gap between previous end and current start
		local gap = curr_entry.startTime - prev_entry.endTime

-                table.insert(
-                    content,
-                    string.format('│ Format: %s                     │', periods_text)
+                -- Pad or truncate periods_text to fit the box width
+                local function pad_or_truncate(str, width)
+                    if #str > width then
+                        return str:sub(1, width)
+                    else
+                        return str .. string.rep(' ', width - #str)
+                    end
+                end
+                local content_width = 51 -- 62 (box width) - 10 ('│ Format: ') - 1 ('│')
+                table.insert(
+                    content,
+                    string.format('│ Format: %s│', pad_or_truncate(periods_text, content_width))

Conversation

Copilot AI commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comments on the Issue (you are @copilot in this section)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes

Reviewed Changes

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

maorun commented Sep 30, 2025

Uh oh!

Copilot AI commented Sep 30, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

maorun commented Sep 30, 2025

Uh oh!

Copilot AI commented Sep 30, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Sep 30, 2025 •

edited

Loading