Skip to content
This repository was archived by the owner on Jun 4, 2026. It is now read-only.

Compiler independent warnings #69

Open
mathisloge wants to merge 9 commits into
mapbox:masterfrom
mathisloge:master
Open

Compiler independent warnings #69
mathisloge wants to merge 9 commits into
mapbox:masterfrom
mathisloge:master

Conversation

@mathisloge

Copy link
Copy Markdown

This is the same as mapnik/mapnik#4189

It will replace gcc/clang specific pragma warnings with compiler independent ones.

@mathisloge

mathisloge commented Dec 16, 2020

Copy link
Copy Markdown
Author

mhm. https://travis-ci.com/github/mapbox/geometry.hpp/jobs/460974148 fails due to the format run.
The line #define MAPBOX_GEOMETRY_DISABLE_WARNING_FLOAT_EQUAL MAPBOX_GEOMETRY_DISABLE_WARNING(-Wfloat-equal) should be formatted to #define MAPBOX_GEOMETRY_DISABLE_WARNING_FLOAT_EQUAL MAPBOX_GEOMETRY_DISABLE_WARNING(-Wfloat - equal)

But that results in a build error because of the spaces between Wfloat and equal. Does any one know how to ignore the formatting at this line?
Is wrapping the line in // clang-format [off/on] enough for the ci?

@mathisloge

Copy link
Copy Markdown
Author

\ping @flippmoke since you seem to be the active maintainer of this repo?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant