Skip to content

API Error Parsing #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
volleio wants to merge 2 commits into
base: master
Choose a base branch
from
Open

API Error Parsing #53

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
096a33d
fix: correct api error message parsing
volleio Jan 22, 2021
46479c8
style: replace `if !` with `unless`
volleio Jan 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions lib/mapbox.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,35 +104,34 @@ def self.general_api_error(rcode, rbody)

def self.handle_api_error(rcode, rbody)
begin
error_obj = JSON.parse(rbody)
error = error_obj[:error] or raise StandardError.new # escape from parsing
error = JSON.parse(rbody)
raise StandardError.new unless error.has_key?("message") # escape from parsing

rescue JSON::ParserError, StandardError
raise general_api_error(rcode, rbody)
end

case rcode
when 400, 404
raise invalid_request_error error, rcode, rbody, error_obj
raise invalid_request_error error, rcode
when 401
raise authentication_error error, rcode, rbody, error_obj
raise authentication_error error, rcode
else
raise api_error error, rcode, rbody, error_obj
raise api_error error, rcode
end

end

def self.invalid_request_error(error, rcode, rbody, error_obj)
StandardError.new(error[:message], error[:param], rcode,
rbody, error_obj)
def self.invalid_request_error(error, rcode)
StandardError.new("Request Error: #{rcode} - #{error["message"]}")
end

def self.authentication_error(error, rcode, rbody, error_obj)
AuthenticationError.new(error[:message], rcode, rbody, error_obj)
def self.authentication_error(error, rcode)
AuthenticationError.new("Authentication Error: #{rcode} - #{error["message"]}")
end

def self.api_error(error, rcode, rbody, error_obj)
StandardError.new(error[:message], rcode, rbody, error_obj)
def self.api_error(error, rcode)
StandardError.new("API Error: #{rcode} - #{error["message"]}")
end

def self.handle_restclient_error(e, api_base_url=nil)
Expand Down