Skip to content

Fix/locale codes#49

Open
ElyesDer wants to merge 2 commits intomapbox:mainfrom
ElyesDer:Fix/LocaleCodes
Open

Fix/locale codes#49
ElyesDer wants to merge 2 commits intomapbox:mainfrom
ElyesDer:Fix/LocaleCodes

Conversation

@ElyesDer
Copy link
Copy Markdown

@ElyesDer ElyesDer commented Feb 8, 2022

Description
This PR fixes an issue with incompatible ISO 639-3 codes between iOS's Locale and Amazon Polly's ISO 639-3.
It was also reported here.

Implementation

  • Store all unsupported language codes returned by Locale in ISO 639-2 format.
  • If SpeechOptions's language identifier is in the list of unsupported, use the supported one instead.
  • Support Arabic (AR) and Chinese (ZH) codes
  • Add support for other unsupported languages

Copy link
Copy Markdown
Contributor

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing this workaround for the longstanding language code issue!

Comment thread Sources/MapboxSpeech/MBSpeechOptions.swift
Comment thread Sources/MapboxSpeech/MBSpeechOptions.swift
Comment thread Sources/MapboxSpeechCLI/main.swift
@1ec5 1ec5 added this to the v2.4 milestone Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants