Fix resolve class members in lists#4525
Merged
Merged
Conversation
exportValueToJson does its own recursion through the value tree, so it needs the context to be in NoRecursion mode. Add a comment explaining why it does not just use TypedListValues (the property types JSON format spells the key "propertyType" where TypedListValues would emit "propertytype") and a matching assertion. Also tweaked some comments in MapToVariantConverter.
bjorn
changed the title
The ExportHelper forgot to recurse into list values.
bjorn
force-pushed
the
fix-resolve-members-in-lists
branch
from
bb60d24 to
ddcf36b
Compare
bjorn
added a commit
that referenced
this pull request
May 22, 2026
The ExportHelper forgot to recurse into list values. Also documented exportValueToJson's NoRecursion precondition and tweaked some comments in MapToVariantConverter. (cherry picked from commit c676301)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ExportHelperforgot to recurse into list values.