[3party] Restoring the server-side OSRM plugin.#14170
Open
mpimenov wants to merge 2 commits intomapsme:masterfrom
Open
[3party] Restoring the server-side OSRM plugin.#14170mpimenov wants to merge 2 commits intomapsme:masterfrom
mpimenov wants to merge 2 commits intomapsme:masterfrom
Conversation
Contributor
|
а почему драфт? |
tatiana-yan
reviewed
Jun 16, 2021
| #define ROUTING_SHORTCUTS_FILE_TAG "skoda" | ||
| #define ROUTING_CROSS_CONTEXT_TAG "chrysler" | ||
|
|
||
| #define ROUTING_FTSEG_FILE_TAG "ftseg" |
Contributor
Author
There was a problem hiding this comment.
поэтому и драфт
сейчас оживлены части, которые нужны для компиляции, но на самом деле не нужны
например, неправильно оставлять в routing/ файлы, не добавленные в cmake
эта версия уже рабочая, но я ещё доделываю
tatiana-yan
reviewed
Jun 16, 2021
| #define ROUTING_CROSS_CONTEXT_TAG "chrysler" | ||
|
|
||
| #define ROUTING_FTSEG_FILE_TAG "ftseg" | ||
| #define ROUTING_NODEIND_TO_FTSEGIND_FILE_TAG "node2ftseg" |
Contributor
There was a problem hiding this comment.
тоже не используется
эти define ещё нужны?
tatiana-yan
reviewed
Jun 16, 2021
| #include "../../../succinct/rs_bit_vector.hpp" | ||
| #include "../../../succinct/mapper.hpp" | ||
|
|
||
| #define ROUTING_MATRIX_FILE_TAG "mercedes" |
Contributor
There was a problem hiding this comment.
это такой вариант обфускации? это ещё нужно или можно назвать routing_matrix и так далее?
Contributor
|
@mpimenov а какую именно проблему задумывалось решить воскрешением OSRM? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.