Normalize implode() argument order for code PHP 8#231
Open
SaidNizamWevetel wants to merge 3 commits intomarcelog:masterfrom
Open
Normalize implode() argument order for code PHP 8#231SaidNizamWevetel wants to merge 3 commits intomarcelog:masterfrom
SaidNizamWevetel wants to merge 3 commits intomarcelog:masterfrom
Conversation
|
This is fixed on master already, but is not included in a numbered release. I had to point our Composer require to: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the implode() call to use the conventional argument order (array, separator) as recommended by the PHP manual.
What was changed
Updated:
$name = implode('', $parts);
to
$name = implode($parts, '');
Why
Both argument orders are accepted by PHP, but the canonical form is implode(array $pieces, string $separator).
Improves consistency with common PHP coding standards.
Makes the code clearer for developers who expect the standard ordering.
Impact
No functional change.
Purely a code-quality improvement.