fix: restore saved export destination mode on image open#603
Merged
marcinz606 merged 1 commit intoJul 22, 2026
Merged
Conversation
The Folder combo stores ExportPresetOutputMode members as item data, but a persisted config round-trips through JSON as a plain string, so findData() never matched and the combo fell back to index 0. The panel showed "Subfolder of source" whatever was saved, and the next edit to any export field wrote that wrong mode back over the saved destination. Normalize the row to the enum before lookup, falling back to Absolute for unknown values. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VcGpSk4mhUGCv7iuUejeTf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #602
The Folder combo stores
ExportPresetOutputModemembers as item data, but a persisted config round-trips through JSON as a plain string, sofindData()never matched and the combo fell back to index 0. The panel showed "Subfolder of source" whatever was saved, and the next edit to any export field wrote that wrong mode back over the saved destination.Normalize the row to the enum before lookup, falling back to
ABSOLUTEfor unknown values.Testing
tests/test_export_settings_form.py: every mode restored from a plain string, and unknown values falling back toABSOLUTE.make allclean (2383 passed, 5 skipped).🤖 Generated with Claude Code
https://claude.ai/code/session_01Nm64ZGh8un7ch3EanYv2K6