fix: support chai 4.1.x peer dependency#40
Open
AndersDJohnson wants to merge 1 commit intomarcodejongh:masterfrom
Open
fix: support chai 4.1.x peer dependency#40AndersDJohnson wants to merge 1 commit intomarcodejongh:masterfrom
AndersDJohnson wants to merge 1 commit intomarcodejongh:masterfrom
Conversation
Collaborator
|
This looks good to me! But did you run into any dependency issues running I opened an issue about this a while ago: #29, but Marco has been away form the project for a while, and I don't have a ton of npm/yarn experience so I'm not sure what I was doing wrong, or whether the packages mentioned there are necessary or common. |
|
Whats going on with this issue? |
Collaborator
|
Not much, I'm sorry to report. This project is in need of some new maintainers, as I (and I believe @marcodejongh) have stopped using webdriverio (not because there's something better, I'm just doing less front-end development these days), and don't currently have spare time to maintain it 😞 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build is failing with
yarnwhen using withchai@4.1.2since this module was expecting4.0.xdue to the use of~in~4.0.1in itspeerDependencies. Butchai4.1.2should be compatible with4.0.xbased on semantic versioning, so it should be safe to allow.