Fix native extension loading for versioned Ruby directories#2
Open
twokidsCarl wants to merge 1 commit intomarcoroth:mainfrom
Open
Fix native extension loading for versioned Ruby directories#2twokidsCarl wants to merge 1 commit intomarcoroth:mainfrom
twokidsCarl wants to merge 1 commit intomarcoroth:mainfrom
Conversation
The precompiled gem ships `.bundle` files under versioned subdirectories
(e.g. `lib/bubblezone/3.4/`, `lib/bubblezone/4.0/`) but the loader
uses `require_relative "bubblezone/bubblezone"` which only looks in the
top-level directory.
Try the versioned path `bubblezone/{major}.{minor}/bubblezone` first,
falling back to the unversioned path. This matches the approach used by
bubbletea-ruby.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The precompiled gem ships native
.bundlefiles under versioned subdirectories:But
lib/bubblezone.rbuses:This only resolves to
lib/bubblezone/bubblezone.bundle(which doesn't exist), causing aLoadErroron all Ruby versions.Fix
Try the versioned path first, fall back to the unversioned path:
This matches the approach already used by bubbletea-ruby.
Test plan
require "bubblezone"now succeeds🤖 Generated with Claude Code