Extract a Gems::BaseController

Gemfile.lock

@@ -329,6 +329,7 @@ GEM
 
 PLATFORMS
   arm64-darwin-22
+  arm64-darwin-23
   x86_64-darwin-22
   x86_64-darwin-23
   x86_64-linux

app/controllers/gems/base_controller.rb

@@ -0,0 +1,33 @@
+class Gems::BaseController < ApplicationController
+  before_action :set_gem
+  def self.set_target(...) = before_action(:set_target, ...)
+
+  rescue_from GemNotFoundError, Gems::NotFound do |exception|
+    redirect_to gems_path, notice: exception.message
+  end
+
+  rescue_from GemConstantNotFoundError do |exception|
+    redirect_to gem_version_gem_path(@gem.name, @gem.version), notice: exception.message
+  end
+
+  private
+
+  def set_gem
+    if gem = params[:gem]
+      version = perams[:version] || GemSpec.latest_version_for(gem)
+      @gem = GemSpec.find(gem, version) or raise GemNotFoundError.new(gem, version)
+    end
+  end
+
+  def set_target
+    @target =
+      case
+      when params[:class_id]  then @gem.find_class!(params[:class_id])
+      when params[:module_id] then @gem.find_module!(params[:module_id])
+      else
+        @gem.info.analyzer
+      end
+
+    @namespace = @gem.find_namespace(@target.qualified_namespace) if params[:class_id]
+  end
+end

app/controllers/gems/class_methods_controller.rb

@@ -1,8 +1,7 @@
 # frozen_string_literal: true
 
-class Gems::ClassMethodsController < ApplicationController
-  include GemScoped
-  include GemTargetScoped
+class Gems::ClassMethodsController < Gems::BaseController
+  set_target
 
   def show
     @method = @target.class_methods.find { |class_method| class_method.name == params[:id] }

app/controllers/gems/classes_controller.rb

@@ -1,13 +1,12 @@
 # frozen_string_literal: true
 
-class Gems::ClassesController < ApplicationController
-  include GemScoped
-  include GemClassScoped
-
+class Gems::ClassesController < Gems::BaseController
   def index
   end
 
   def show
+    @class = @gem.find_class!(params[:id])
+
     @classes = @gem.classes.select { |klass| klass.qualified_namespace == @class.qualified_name }
     @namespace = @gem.find_namespace(@class.qualified_namespace)
   end

app/controllers/gems/docs_controller.rb

@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
-class Gems::DocsController < ApplicationController
-  include GemScoped
-
+class Gems::DocsController < Gems::BaseController
   def index
   end
 

app/controllers/gems/files_controller.rb

@@ -1,12 +1,17 @@
 # frozen_string_literal: true
 
-class Gems::FilesController < ApplicationController
-  include GemScoped
-  include GemFileScoped
+class Gems::FilesController < Gems::BaseController
+  before_action :set_file
 
   def index
   end
 
   def show
   end
+
+  private
+
+  def set_file
+    @file = SourceFile.new(gem: @gem, file: params[:id]).existent
+  end
 end

app/controllers/gems/guides_controller.rb

@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
-class Gems::GuidesController < ApplicationController
-  include GemScoped
-
+class Gems::GuidesController < Gems::BaseController
   def index
   end
 

app/controllers/gems/instance_methods_controller.rb

@@ -1,8 +1,7 @@
 # frozen_string_literal: true
 
-class Gems::InstanceMethodsController < ApplicationController
-  include GemScoped
-  include GemTargetScoped
+class Gems::InstanceMethodsController < Gems::BaseController
+  set_target
 
   def show
     @method = @target.instance_methods.find { |instance_method| instance_method.name == params[:id] }

app/controllers/gems/modules_controller.rb

@@ -1,13 +1,12 @@
 # frozen_string_literal: true
 
-class Gems::ModulesController < ApplicationController
-  include GemScoped
-  include GemModuleScoped
-
+class Gems::ModulesController < Gems::BaseController
   def index
   end
 
   def show
+    @module = @gem.find_module!(params[:id])
+
     @modules = @gem.modules.select { |mod| mod.qualified_namespace == @module.qualified_name }
     @classes = @gem.classes.select { |klass| klass.qualified_namespace == @module.qualified_name }
   end

app/controllers/gems/pages_controller.rb

@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
-class Gems::PagesController < ApplicationController
-  include GemScoped
-
+class Gems::PagesController < Gems::BaseController
   def show
     render params[:id].to_sym
   end

app/controllers/gems/rbs_controller.rb

@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
-class Gems::RBSController < ApplicationController
-  include GemScoped
-
+class Gems::RBSController < Gems::BaseController
   def index
     require_samples = params[:require_samples].present?
     signature = @gem.rbs_signature(require_samples:)

app/controllers/gems/search_controller.rb

@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
-class Gems::SearchController < ApplicationController
-  include GemScoped
-
+class Gems::SearchController < Gems::BaseController
   def index
     query = params[:q].to_s.downcase
 

app/controllers/gems/types_controller.rb

@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
-class Gems::TypesController < ApplicationController
-  include GemScoped
-
+class Gems::TypesController < Gems::BaseController
   def index
     @samples = Types::Sample
                .group(:gem_name, :gem_version, :receiver, :method_name)

app/controllers/gems/versions_controller.rb

@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
-class Gems::VersionsController < ApplicationController
-  include GemScoped
-
+class Gems::VersionsController < Gems::BaseController
   def index
   end
 end

app/controllers/gems_controller.rb

@@ -1,10 +1,6 @@
 # frozen_string_literal: true
 
-class GemsController < ApplicationController
-  include GemScoped
-
-  before_action :set_gem, except: :index
-
+class GemsController < Gems::BaseController
   def index
     @gems = Gems.just_updated
   end

app/models/source_file.rb

@@ -13,6 +13,10 @@ def source_path
     "#{gem.unpack_data_path}/#{file}"
   end
 
+  def existent
+    self if exist?
+  end
+
   def exist?
     file && gem.files.include?(file) && File.exist?(source_path)
   end

config/database.yml

@@ -57,8 +57,6 @@ test:
   <<: *default
   database: gemsh_test
   host: localhost
-  username: postgres
-  password: postgres
 
 # As with config/credentials.yml, you never want to store sensitive information,
 # like your database password, in your source code. If your source code is