fix: resolve gocritic if-else chains and godot comment style#109
Open
camr wants to merge 1 commit intomarcus:mainfrom
Open
fix: resolve gocritic if-else chains and godot comment style#109camr wants to merge 1 commit intomarcus:mainfrom
camr wants to merge 1 commit intomarcus:mainfrom
Conversation
Add .golangci.yml enabling gocritic and godot linters. Rewrite two if-else chains flagged by gocritic as switch candidates (in Parse and wrapText). Add missing trailing periods to godoc comments in pkg/commit/normalizer.go. Nightshift-Task: lint-fix Nightshift-Ref: https://github.com/marcus/nightshift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.golangci.ymlenablinggocriticandgodotlinters for consistent CI enforcementif-elsechains flagged bygocriticas switch candidates: one inParse(footerStart/bodyStart comparison) and one inwrapText(word-loop logic)pkg/commit/normalizer.goto satisfygodotTest plan
go test ./pkg/commit/...passes with no failuresgolangci-lint run ./pkg/commit/...reports 0 issues with the new.golangci.yml🤖 Generated with Claude Code
Automated by nightshift