You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Apparently, react-markdown has been updated recently, fixing some problems in rendering tables.
However, this required not using the inline prop anymore.
This PR should fix it (I am using it this way currently and will report back if I find something breaking) but I would appreciate some feedback, as this is my first JS/TS project.
Hi @YYYasin19, thanks for your PR! Some checks are failing, especially the deployment of apps/www (that app is running on https://ui.marcusschiesser.de/) - can you have a look at this? Then I'll happy to merge your changes
I think I've fixed formatting and the typing issues but it still doesn't seem to deploy correctly.
I can't see more details, though, since I'm not configured on the Vercel project :/
Alright, the problem seems to be connected to this collection ofissues.
This means this PR will have to wait a little bit more until other tools are updated as well. The specific problem here seems to connected to mdast.
I don't get which dependency is still broken
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for the great Chat UI!
Apparently,
react-markdownhas been updated recently, fixing some problems in rendering tables.However, this required not using the
inlineprop anymore.This PR should fix it (I am using it this way currently and will report back if I find something breaking) but I would appreciate some feedback, as this is my first JS/TS project.
Thanks!