Skip to content

Make sure FFF_LS_COLORS and FFF_HIDDEN is checked after sourcing FFF_CONFIG. #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amd64-little wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make sure FFF_LS_COLORS and FFF_HIDDEN is checked after sourcing FFF_CONFIG. #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,8 +167,6 @@ Ctrl+C: exit without 'cd'.

`FFF_CONFIG` can be added to your `bashrc` (or other shell's configuration files). Everything put in `FFF_CONFIG` file will be sourced globally meaning that e.g. Neovim's terminal will have these settings.

Personal note (can be unreproducible for your): I'm not sure why the only option (maybe there are others) not working in config file is `FFF_HIDDEN` which only works, when fff is run inside terminal manually.

```sh
# Show/Hide hidden files on open.
# (Off by default)
Expand Down
13 changes: 7 additions & 6 deletions fff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1986,12 +1986,6 @@ main() {
((BASH_VERSINFO[0] > 3)) &&
read_flags=(-t 0.05)

((${FFF_LS_COLORS:=1} == 1)) &&
get_ls_colors

((${FFF_HIDDEN:=0} == 1)) &&
shopt -s dotglob

# Create the trash and cache directory if they don't exist.
mkdir -p "${XDG_CACHE_HOME:=${HOME}/.cache}/fff" \
"${FFF_TRASH:=${XDG_DATA_HOME:=${HOME}/.local/share}/fff/trash}"
Expand All @@ -2009,6 +2003,13 @@ main() {
get_os
get_term_size
setup_options

((${FFF_LS_COLORS:=1} == 1)) &&
get_ls_colors

((${FFF_HIDDEN:=0} == 1)) &&
shopt -s dotglob

setup_terminal
redraw full

Expand Down