Skip to content

fix(ios): enable SQLite performance mode#291

Merged
chrispader merged 4 commits into
mainfrom
codex/fix-podspec-performance-mode
Jul 23, 2026
Merged

fix(ios): enable SQLite performance mode#291
chrispader merged 4 commits into
mainfrom
codex/fix-podspec-performance-mode

Conversation

@chrispader

Copy link
Copy Markdown
Member

Summary

  • compare performance_mode using its integer type
  • write performance flags through s.pod_target_xcconfig
  • make the two performance modes mutually exclusive

Root cause

performance_mode is initialized as an integer but was compared with string values, so neither branch executed. This also masked references to an undefined xcconfig variable inside both branches.

Impact

The configured default performance mode now applies the intended SQLite compiler options, including SQLITE_THREADSAFE=0 for mode 1.

Validation

  • ruby -c packages/react-native-nitro-sqlite/RNNitroSQLite.podspec
  • git diff --check

@chrispader
chrispader marked this pull request as ready for review July 23, 2026 15:24
@chrispader
chrispader merged commit 718ef3e into main Jul 23, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant