Fix buffer.sequence for mmap#1
Open
mariannasb wants to merge 1 commit into
Open
Conversation
When using gstreamer for streaming frames into the loopback the sequence number on the v4l2 buffers read out of the loopback stays at zero.
When using FFMPEG instead to populate the loopback device the sequence number increases as expected.
The difference is that FFMPEG uses 'rw' ('write') while gstreamer uses 'mmap' ('qbuf'/'dqbuf').
And 'b->sequence' was currently only being set to 'dev->write_position' in 'v4l2_loopback_write()', but not in 'vidioc_qbuf()'.
See v4l2loopback#466
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using gstreamer for streaming frames into the loopback the sequence number on the v4l2 buffers read out of the loopback stays at zero.
When using FFMPEG instead to populate the loopback device the sequence number increases as expected.
The difference is that FFMPEG uses 'rw' ('write') while gstreamer uses 'mmap' ('qbuf'/'dqbuf').
And 'b->sequence' was currently only being set to 'dev->write_position' in 'v4l2_loopback_write()', but not in 'vidioc_qbuf()'.
See v4l2loopback#466