fix(ci): bump release publish-job node to 24 for npm OIDC#59
Closed
mscolnick wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub Actions release workflow to use Node.js 24 so the bundled npm version supports npm Trusted Publishing via OIDC, allowing tagged releases (v*) to publish successfully without installing a newer npm globally.
Changes:
- Bump
actions/setup-nodein the release workflow from Node 22 to Node 24 to restore OIDC-compatible npm fornpm publish.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
23
to
28
| - name: ⎔ Setup Node.js | ||
| uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4 | ||
| with: | ||
| node-version: 22 | ||
| node-version: 24 | ||
| registry-url: "https://registry.npmjs.org" | ||
| cache: pnpm |
Contributor
Author
|
Superseded — #58 (the batch-C release split) merged and already bumps publish-job node to 24. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm install -g npm@latestwas recently removed, but the release.ymlpublishstep still pinsnode-version: 22(or20), whose bundled npm 10.x does not support npm trusted publishing (OIDC). This restores OIDC by bumping the publish step to node 24 (bundled npm 11+).Once this lands, the next
v*tag will publish successfully via OIDC.