chore(ci): split release.yml into build/publish/release-notes/notify jobs#11
Merged
Conversation
Coverage Report
File CoverageNo changed files found. |
There was a problem hiding this comment.
Pull request overview
This PR restructures the release GitHub Actions workflow to minimize privileged token exposure during npm publishing, addressing the oidc-publish-fused supply-chain audit finding by isolating id-token: write to a dedicated publish job.
Changes:
- Split the previous single release job into
build,publish,release-notes, andnotifyjobs with tighter per-job permissions. - Publish via a downloaded build artifact and run
npm publish --ignore-scriptsunder the only job grantedid-token: write. - Add a final
notifyjob that always runs and aggregatesneeds.*.resultfor Slack notifications.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
109
to
112
| - name: 📝 Update Changelog | ||
| run: npx changelogithub | ||
| env: | ||
| GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} |
|
|
||
|
|
||
| - name: 📥 Install dependencies | ||
| run: pnpm install --frozen-lockfile |
Comment on lines
+83
to
+87
| - name: ⎔ Setup Node.js | ||
| uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4 | ||
| with: | ||
| node-version: 24 | ||
| registry-url: 'https://registry.npmjs.org' |
| - name: ⎔ Setup Node.js | ||
| uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4 | ||
| with: | ||
| node-version: 24 |
mscolnick
force-pushed
the
myles/release-artifact-handoff
branch
from
9ed60c7 to
62c2694
Compare
Contributor
Author
|
Intentional: only the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits the single release job into 4 jobs so the
id-token: writescope is held only by a publish job that runsnpm publishexclusively (no install/test/build/exec).id-token): install, typecheck, test, build, validate, uploaddist/+ package metadata as artifact.id-token: write): download artifact,npm publish --ignore-scripts.contents: write, noid-token):npx changelogithub.if: always()): slack notification, aggregatesneeds.*.result.Resolves the supply-chain audit
oidc-publish-fusedfinding. Motivated by the TanStack npm supply-chain compromise (May 2026).