Skip to content

chore(ci): add --ignore-scripts to release installs#125

Closed
mscolnick wants to merge 1 commit into
mainfrom
myles/audit-ignore-scripts
Closed

chore(ci): add --ignore-scripts to release installs#125
mscolnick wants to merge 1 commit into
mainfrom
myles/audit-ignore-scripts

Conversation

@mscolnick
Copy link
Copy Markdown
Contributor

Defense-in-depth against compromised transitive deps executing postinstall/prepare during release. Motivated by the TanStack npm supply-chain compromise (May 2026).

No functional change.

Copilot AI review requested due to automatic review settings May 12, 2026 16:13
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR hardens the GitHub Actions release workflow by adding pnpm install --ignore-scripts to reduce the risk of compromised dependencies running lifecycle scripts during the release process.

Changes:

  • Add --ignore-scripts when globally installing npm@latest in the release workflow.
  • Add --ignore-scripts to the main dependency install step in the release workflow.
Comments suppressed due to low confidence (1)

.github/workflows/release.yml:40

  • pnpm install --ignore-scripts will skip Playwright’s install hooks. Since pnpm run test runs a Vitest browser project (see vite.config.ts), the release workflow likely needs an explicit pnpm exec playwright install chromium step (as done in .github/workflows/test.yml) or otherwise ensure browser tests are disabled in release; otherwise the release job may fail due to missing browsers.
      - name: 📥 Install dependencies
        run: pnpm install --ignore-scripts --frozen-lockfile

      - name: 🔍 Type Check
        run: pnpm run typecheck

      - name: 🧪 Test
        run: pnpm run test

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mscolnick
Copy link
Copy Markdown
Contributor Author

This is already covered by pnpm 10 — closing.

@mscolnick mscolnick closed this May 12, 2026
@mscolnick mscolnick deleted the myles/audit-ignore-scripts branch May 12, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants