couple of notebook added for review#122
Conversation
|
Hi @tusharrrr1; I'm currently at the IndiaFOSS event advocating for marimo. I'll review this PR once I get back from the event; apologies for the delay. Thanks a lot for the contribs, look forward to seeing the notebook contents! |
|
hey @Haleshot All luck to you for the event, no worries for the delay |
Haleshot
left a comment
There was a problem hiding this comment.
Hey, sorry for the delayed response on this - been dealing with some irl job stuff that's been taking up a lot of time.
So first thing - I typically ask for one notebook per PR, not multiple. Makes the review process cleaner and easier to focus on getting each notebook right individually.
Looking at what you've submitted here for #120, I'm trying to figure out what angle you're going for with these notebooks. I believe I had already listed out a Linear Algebra series that I linked in the issue thread - those notebooks cover vectors, operations, matrix transformations, interactive visualizations w/ marimo UI elements & both column/row perspectives. Looking at the notebooks in this PR; I notice something along those lines (lesser in terms of content and any actual outcome for the notebook).
The 02_linear_transformations.py file has broken LaTeX - I'm seeing stuff like egin{bmatrix} and os heta instead of proper rendering. Also starting the title with "2." doesn't make much sense. The linear_algebra_foundations.py is a walkthrough of basics, again, something that can be seen in my short collection of Linear Algebra notebooks.
Looking at the issue thread, I believe I had mentioned checking out topics that aren't already covered - SVD, eigenvalues, actual ML applications like face recognition, PCA (even linked to a SVD notebook that was one-shotted via marimo AI).
📝 Summary
added the linear algebra course with couple of notebooks for review.