Open
Conversation
Haleshot
reviewed
May 15, 2025
Contributor
Haleshot
left a comment
Haleshot
left a comment
There was a problem hiding this comment.
Great first notebook contrib with good interactive elements! Just some comments overall:
- Make explanations specific to the dataset chosen, not just general desc (or what happens on varying the params/UI elements like sliders). Some fun facts/anomalies if any, which you might find on varying the params and the plots reflecting those changes.
- Personal insights about what the visualizations reveal in this specific data (own words)
- Consider adding a short comparison of when to use each visualization type
Co-authored-by: Srihari Thyagarajan <57552973+Haleshot@users.noreply.github.com>
Co-authored-by: Srihari Thyagarajan <57552973+Haleshot@users.noreply.github.com>
Co-authored-by: Srihari Thyagarajan <57552973+Haleshot@users.noreply.github.com>
Co-authored-by: Srihari Thyagarajan <57552973+Haleshot@users.noreply.github.com>
Co-authored-by: Srihari Thyagarajan <57552973+Haleshot@users.noreply.github.com>
Co-authored-by: Srihari Thyagarajan <57552973+Haleshot@users.noreply.github.com>
Co-authored-by: Srihari Thyagarajan <57552973+Haleshot@users.noreply.github.com>
Co-authored-by: Srihari Thyagarajan <57552973+Haleshot@users.noreply.github.com>
Contributor
|
@BryanZhang938 Let me know if you need any help in addressing the main review comments (left in the PR comment above). Mainly in relation to explaining the plots & having explanations tailored to the plots. |
Haleshot
reviewed
Jun 1, 2025
| return | ||
|
|
||
|
|
||
| @app.cell |
Contributor
There was a problem hiding this comment.
Suggested change
| @app.cell | |
| @app.cell(hide_code=True) |
Can we hide all markdown cells listed in the notebook?
Haleshot
reviewed
Jun 1, 2025
| return | ||
|
|
||
|
|
||
| @app.cell |
Contributor
There was a problem hiding this comment.
I would separate the markdown section in separate cells in accordance with each section.
Contributor
|
@BryanZhang938 Wondering if you had a chance to look at this PR again (& the review comments posted above). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
I created a Marimo notebook for the Statistical Charts lesson in the Plotly course. Let me know if there are any questions or concerns.
#70
📋 Checklist
--sandboxREADME.md