-
Notifications
You must be signed in to change notification settings - Fork 1k
[nd 6/5] Back NotebookDocument cell text with Loro CRDT
#8849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
manzt
wants to merge
6
commits into
main
Choose a base branch
from
manzt/nd-loro
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c82654c
Emit document transactions from --watch file reload
manzt 69d18cc
Back NotebookDocument cell text with Loro CRDT
manzt 7c0c578
Unify LoroDocManager with session's LoroDoc
manzt 5670c97
Route cell text through Loro on the frontend
manzt f45ac4e
Clean up Loro integration and fix stale RTC tests
manzt 138999b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| # Copyright 2026 Marimo. All rights reserved. | ||
| """Notebook document model — canonical representation of notebook structure.""" | ||
|
|
||
| from marimo._messaging.notebook.changes import ( | ||
| CreateCell, | ||
| DeleteCell, | ||
| DocumentChange, | ||
| MoveCell, | ||
| ReorderCells, | ||
| SetCode, | ||
| SetConfig, | ||
| SetName, | ||
| Transaction, | ||
| ) | ||
| from marimo._notebook.document import CellMeta, NotebookCell, NotebookDocument | ||
|
|
||
| __all__ = [ | ||
| "CellMeta", | ||
| "CreateCell", | ||
| "DeleteCell", | ||
| "DocumentChange", | ||
| "MoveCell", | ||
| "NotebookCell", | ||
| "NotebookDocument", | ||
| "ReorderCells", | ||
| "SetCode", | ||
| "SetConfig", | ||
| "SetName", | ||
| "Transaction", | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| # Copyright 2026 Marimo. All rights reserved. | ||
| """Typed wrappers for ``loro`` APIs with incomplete stubs. | ||
|
|
||
| The ``loro`` stubs omit return types on ``__new__`` and the | ||
| ``ValueOrContainer`` union lacks a typed ``.container`` accessor. | ||
| These helpers isolate the ``type: ignore`` comments so the rest of | ||
| the codebase stays clean. | ||
| """ | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| from loro import LoroDoc, LoroText, ValueOrContainer | ||
|
|
||
|
|
||
| def create_doc() -> LoroDoc: | ||
| return LoroDoc() # type: ignore[no-untyped-call] | ||
|
|
||
|
|
||
| def create_text() -> LoroText: | ||
| return LoroText() # type: ignore[no-untyped-call] | ||
|
|
||
|
|
||
| def unwrap_text(val: ValueOrContainer) -> LoroText: | ||
| """Extract a ``LoroText`` from a ``ValueOrContainer``.""" | ||
| container = val.container # type: ignore[union-attr,attr-defined] | ||
| assert isinstance(container, LoroText) | ||
| return container | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should raise upstream tbh