fix: support CloudPath subclasses in normalize_path and file_browser#8879
Open
BillionClaw wants to merge 1 commit intomarimo-team:mainfrom
Open
fix: support CloudPath subclasses in normalize_path and file_browser#8879BillionClaw wants to merge 1 commit intomarimo-team:mainfrom
BillionClaw wants to merge 1 commit intomarimo-team:mainfrom
Conversation
Use isinstance(path, CloudPath) instead of checking __module__ name, so that custom cloudpathlib providers (e.g., SMBPath) that extend CloudPath are properly recognized and bypass normalization. Fixes marimo-team#8868
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Support CloudPath subclasses in path normalization
Problem
Custom cloudpathlib providers (e.g., SMBPath) that subclass CloudPath were not recognized by marimo's path handling because normalize_path and the file browser used a fragile module-name check:
This only matched the built-in S3Path, GSPath, AzurePath etc., but not user-created subclasses whose module would be their own package (e.g., mypackage.smbpath).
As a result, os.path.normpath was called on cloud paths, corrupting URI schemes like smb://server/share into smb:/server/share.
Solution
Replace the module-name check with isinstance(path, CloudPath), which correctly identifies all subclasses of CloudPath. The old module-name check is kept as a fallback for backward compatibility.
Changes
Testing
All 15 tests in tests/_utils/test_paths.py pass.
Fixes #8868.