fix: preserve style_cell mapping when table sorted descending#8912
Open
joaquinhuigomez wants to merge 2 commits intomarimo-team:mainfrom
Open
fix: preserve style_cell mapping when table sorted descending#8912joaquinhuigomez wants to merge 2 commits intomarimo-team:mainfrom
joaquinhuigomez wants to merge 2 commits intomarimo-team:mainfrom
Conversation
Row styles should be tied to data indices, not display order. Removing the descending reversal of row_ids fixes misapplied styles when sorting in descending order. Closes marimo-team#8847
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Row styles should be tied to data indices, not display order. The
_style_cellsand_hover_cellsfunctions reversedrow_idswhen sorting descending, causing styles to be applied to the wrong rows.Removes the reversal so style functions always receive the correct data row index regardless of sort direction. Also removes the now-unused
descendingparameter from both functions.Closes #8847