Skip to content

chore: pin pnpm via packageManager#39

Merged
mscolnick merged 1 commit into
mainfrom
chore/pnpm-version-pin
May 12, 2026
Merged

chore: pin pnpm via packageManager#39
mscolnick merged 1 commit into
mainfrom
chore/pnpm-version-pin

Conversation

@mscolnick
Copy link
Copy Markdown
Collaborator

Adds "packageManager": "pnpm@10.28.2" to package.json and drops the redundant version: arg from pnpm/action-setup in CI.

The action now reads the version from packageManager, giving a single source of truth shared between local dev and CI. Matches the convention used in marimo and marimo-lsp.

Adds packageManager: pnpm@10.28.2 to package.json and drops the
redundant `version:` arg from pnpm/action-setup. The action now reads
the version from packageManager, giving a single source of truth shared
between local dev and CI.
Copilot AI review requested due to automatic review settings May 12, 2026 15:07
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pins the project’s pnpm version in package.json via the packageManager field and updates GitHub Actions workflows to rely on that single source of truth, removing the redundant pnpm version specification in CI/release.

Changes:

  • Add "packageManager": "pnpm@10.28.2" to package.json.
  • Remove with: version: 10 from pnpm/action-setup in CI and release workflows so the action resolves pnpm from packageManager.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
package.json Adds packageManager to centrally pin the pnpm version for local dev + CI.
.github/workflows/release.yml Removes explicit pnpm version input so the action reads from packageManager.
.github/workflows/ci.yml Removes explicit pnpm version input across jobs so CI uses the pinned version from packageManager.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mscolnick mscolnick merged commit b6ca79a into main May 12, 2026
7 checks passed
@mscolnick mscolnick deleted the chore/pnpm-version-pin branch May 12, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants