Skip to content

chore(ci): add --ignore-scripts to pnpm install#41

Closed
mscolnick wants to merge 1 commit into
mainfrom
myles/audit-ignore-scripts
Closed

chore(ci): add --ignore-scripts to pnpm install#41
mscolnick wants to merge 1 commit into
mainfrom
myles/audit-ignore-scripts

Conversation

@mscolnick
Copy link
Copy Markdown
Collaborator

Defense-in-depth against compromised transitive deps executing postinstall/prepare in CI. Motivated by the TanStack npm supply-chain compromise (May 2026).

No functional change — lint/typecheck/test do not depend on lifecycle scripts.

Copilot AI review requested due to automatic review settings May 12, 2026 16:10
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GitHub Actions CI workflow to disable running npm/pnpm lifecycle scripts during dependency installation, as a defense-in-depth measure against supply-chain attacks in transitive dependencies.

Changes:

  • Add --ignore-scripts to pnpm install in the lint job
  • Add --ignore-scripts to pnpm install in the typecheck job
  • Add --ignore-scripts to pnpm install in the test job

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mscolnick
Copy link
Copy Markdown
Collaborator Author

This is already covered by pnpm 10 — closing.

@mscolnick mscolnick closed this May 12, 2026
@mscolnick mscolnick deleted the myles/audit-ignore-scripts branch May 12, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants