Skip to content

Issue 45 fix#50

Closed
G0rocks wants to merge 3 commits intomarinlauber:masterfrom
G0rocks:issue_45
Closed

Issue 45 fix#50
G0rocks wants to merge 3 commits intomarinlauber:masterfrom
G0rocks:issue_45

Conversation

@G0rocks
Copy link

@G0rocks G0rocks commented Feb 18, 2026

Fixes issue #45
Also contains the code from the other PR I made, I'm sure I can figure out how to change that at some point but don't feel like doing it right now.

@marinlauber
Copy link
Owner

@G0rocks Nice little function! However, I don't think this goes in the source code of this package; it's very specific, and it doesn't need to be hard-coded into the source to work. The VPP.store is accessible from the main script.

Alternatively, you could add it in the UtilsMod.py file, where it would make more sense to have it.

@G0rocks
Copy link
Author

G0rocks commented Feb 19, 2026

Thanks :)
And actually, until this issue is dealt with then it basically needs to be hardcoded in to work.

So if I understand you correctly, you mean that anybody who wants to use python-VPP to write the polar plot data into a csv file should make their own code to make that happen and that python-VPP can and should only be able to output the polar plot into the results.json file?

But I can move it to UtilsMod.py and it can stay? Because I need to work with this polar after generating it and can not use the json file. Using the csv file makes it way more usable to my use case.

@G0rocks
Copy link
Author

G0rocks commented Feb 19, 2026

As the other issues, #42 and #43, are dealt with in PR #51 then I'm going to close this PR and make a new one just for issue #45

@G0rocks G0rocks closed this Feb 19, 2026
@drizham
Copy link

drizham commented Feb 19, 2026 via email

@G0rocks
Copy link
Author

G0rocks commented Feb 19, 2026

Moving this to the UtilsMod.py was a little bit of a tricky thing because of the dependencies but worked eventually. Please check the new PR, approve and merge when it is ready.
Here is the link:
#52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants