fix: preserve code spans adjacent to tildes#4012
Open
Hona wants to merge 3 commits into
Open
Conversation
|
@Hona is attempting to deploy a commit to the MarkedJS Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Pull request overview
Fixes a GFM inline parsing edge case where a literal ~ immediately adjacent to backtick runs could cause the inline “text” rule to consume part of a code span opener/closer, leading to shifted/incorrect code span pairing (as described in #4011).
Changes:
- Adjusted the GFM inline
textregex to keep adjacent tilde and backtick delimiter runs separate (\+vs~+`), so the codespan tokenizer still sees complete backtick runs. - Added a new spec test covering both delimiter orders, multi-backtick code spans, and code nested in strikethrough.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/specs/new/codespan_adjacent_tilde.md | Adds markdown fixtures reproducing the adjacency cases that previously broke codespan pairing. |
| test/specs/new/codespan_adjacent_tilde.html | Adds expected HTML output for the new adjacency fixtures to prevent regressions. |
| src/rules.ts | Updates the GFM inline text rule so it no longer collapses mixed `/~ runs into a single token that can hide codespan delimiters. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marked version: master / 18.0.5
Markdown flavor: GitHub Flavored Markdown
Description
Contributor
Committer
In most cases, this should be a different person than the contributor.