PDP-817: Introducing the support to execute Arm regressions #1890
Conversation
…ation paths to consider
…gradle.properties file
nagalakshmi2024
requested review from
BillFarber,
rjrudin and
stevebio
as code owners
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Pull request overview
This PR introduces support for running Java client API regressions on ARM-based infrastructure. The implementation adds infrastructure provisioning, ARM-specific configuration, and cleanup logic for ARM regression testing.
Changes:
- Added
arm_regressionsparameter and conditional logic to support ARM and AMD64 architectures - Introduced infrastructure provisioning stage that deploys ARM-based EC2 instances and Jenkins agents
- Updated Docker Compose configuration to support platform-specific settings and converter installation options
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| docker-compose.yaml | Made platform and converter installation configurable via environment variables to support ARM architecture |
| Jenkinsfile | Added ARM infrastructure provisioning, ARM-specific Java paths, platform detection, and cleanup logic for ARM regression testing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| MARKLOGIC_IMAGE=''' + image + ''' MARKLOGIC_LOGS_VOLUME=marklogicLogs \ | ||
| docker compose up -d --build | ||
| echo "Waiting for MarkLogic server to initialize." | ||
| sleep 300 |
There was a problem hiding this comment.
The sleep duration increased from 60s to 300s (5 minutes) without explanation. This significant change affects all builds, not just ARM regressions. Consider making this configurable based on the platform or adding a comment explaining why ARM infrastructure requires a longer initialization time.
|
|
||
| MARKLOGIC_IMAGE=''' + image + ''' MARKLOGIC_LOGS_VOLUME=marklogicLogs \ | ||
| docker compose up -d --build | ||
| echo "Waiting for MarkLogic server to initialize." |
There was a problem hiding this comment.
Inconsistent indentation: this line uses tabs while surrounding lines use spaces.
rjrudin
left a comment
rjrudin
left a comment
There was a problem hiding this comment.
In addition to pointing to develop and squashing and rebasing, try to minimize the number of changed lines in Jenkinsfile due to whitespace. Your editor should be using the .editorconfig file in the root of this repository, which will set indents to tabs (for better or worse).
| platform: "${PLATFORM:-linux/amd64}" | ||
| environment: | ||
| - INSTALL_CONVERTERS=true | ||
| - INSTALL_CONVERTERS=${SET_CONVERTERS:-true} |
There was a problem hiding this comment.
Use "MARKLOGIC_INSTALL_CONVERTERS" as the Docker env var name, as "set" is misleading.
| MARKLOGIC_IMAGE=''' + image + ''' MARKLOGIC_LOGS_VOLUME=marklogicLogs \ | ||
| docker compose up -d --build | ||
| echo "Waiting for MarkLogic server to initialize." | ||
| sleep 300 |
There was a problem hiding this comment.
This line won't be needed when merging to develop - we use a new ml-gradle task that will wait for MarkLogic to be ready.
The changes made to the jenkinsfile to support
provision arm based infrastructure and execute regressions on arm ec2 instance when arm_regressions parameter is enabled
Jenkins console log for arm regressions
https://ml-clt-jenkins.progress.com/job/devexp/job/Java-Client/job/java-client-api-regression/job/arm-regressions-testbranch/108/console