trying again#7
Open
d1rtym0nk3y wants to merge 5 commits into
Open
Conversation
Owner
|
Looks good. I'll do a local merge and run it through the test suite, and should be good to go. |
Contributor
Author
|
I didn't realize it would automatically add this extra commit, clever. maybe too clever! |
added 2 commits
September 21, 2017 09:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes as per pull request #6.
removed try/catch replaced with meta.type check
not sure where all the old commit info came from, but a reset --hard upstream/develop on my local develop branch fixed things.