Skip to content

fix(create): don't fail scaffold on pnpm install exit code#230

Closed
DylanPiercey wants to merge 1 commit into
mainfrom
dpiercey-ws-cli-create-n9kgdk
Closed

fix(create): don't fail scaffold on pnpm install exit code#230
DylanPiercey wants to merge 1 commit into
mainfrom
dpiercey-ws-cli-create-n9kgdk

Conversation

@DylanPiercey

Copy link
Copy Markdown
Contributor

pnpm create marko reported failure even though the project was created fine. Modern pnpm exits non-zero when it skips dependency build scripts (ERR_PNPM_IGNORED_BUILDS, e.g. esbuild), and create treated any non-zero install exit as fatal — so it aborted before git init and printed a bare exited with code 1.

Now a non-zero install is a warning that still completes scaffolding, the package manager's output is shown instead of swallowed (stdio: inherit), and the success message hints to finish install manually when it didn't complete cleanly. Also spawns the child process without an args array under shell: true to fix Node's DEP0190 deprecation warning the CLI was emitting.

Modern pnpm exits non-zero when it skips dependency build scripts
(ERR_PNPM_IGNORED_BUILDS), which caused `create` to report the whole
scaffold as failed even though the project was usable. Install failures
are now a warning that still completes scaffolding, installer output is
shown instead of swallowed, and the child process is spawned without an
args array under `shell: true` to avoid Node's DEP0190 warning.
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 19 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3d2b11b3-6b50-407e-ab76-c64ec280696a

📥 Commits

Reviewing files that changed from the base of the PR and between c66d735 and 7c42906.

📒 Files selected for processing (3)
  • packages/create/src/cli.js
  • packages/create/src/exec.js
  • packages/create/src/index.js
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dpiercey-ws-cli-create-n9kgdk

Comment @coderabbitai help to get the list of available commands.

@DylanPiercey

Copy link
Copy Markdown
Contributor Author

Folding this into a broader PR on the same branch that also drops the legacy packages (test/serve/build/prettyprint/migrate) and modernizes the CLI tooling. The pristine full-package history is preserved on the new legacy branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant