fix(create): don't fail scaffold on pnpm install exit code#230
fix(create): don't fail scaffold on pnpm install exit code#230DylanPiercey wants to merge 1 commit into
Conversation
Modern pnpm exits non-zero when it skips dependency build scripts (ERR_PNPM_IGNORED_BUILDS), which caused `create` to report the whole scaffold as failed even though the project was usable. Install failures are now a warning that still completes scaffolding, installer output is shown instead of swallowed, and the child process is spawned without an args array under `shell: true` to avoid Node's DEP0190 warning.
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 19 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Folding this into a broader PR on the same branch that also drops the legacy packages (test/serve/build/prettyprint/migrate) and modernizes the CLI tooling. The pristine full-package history is preserved on the new |
pnpm create markoreported failure even though the project was created fine. Modern pnpm exits non-zero when it skips dependency build scripts (ERR_PNPM_IGNORED_BUILDS, e.g. esbuild), andcreatetreated any non-zero install exit as fatal — so it aborted before git init and printed a bareexited with code 1.Now a non-zero install is a warning that still completes scaffolding, the package manager's output is shown instead of swallowed (
stdio: inherit), and the success message hints to finishinstallmanually when it didn't complete cleanly. Also spawns the child process without an args array undershell: trueto fix Node's DEP0190 deprecation warning the CLI was emitting.